Take rate #83
Take rate #83
Conversation
| @@ -2197,6 +2201,71 @@ fn process_update_reserve_config( | |||
| Ok(()) | |||
| } | |||
|
|
|||
| #[inline(never)] // avoid stack frame limit | |||
| fn process_redeem_fees(program_id: &Pubkey, accounts: &[AccountInfo]) -> ProgramResult { | |||
There was a problem hiding this comment.
Should we restrict who can execute this function for security as its protocol specific? E.g only allowed by the market owner
There was a problem hiding this comment.
I think it's not needed because the function sends the fees to reserve.config.fee_receiver only, so it doesn't really matter who triggers this instruction.
There was a problem hiding this comment.
i think we specifically dont want to limit it because want to set up a crank to call it once a day from a non essential address
| @@ -381,6 +382,8 @@ pub struct ReserveLiquidity { | |||
| pub borrowed_amount_wads: Decimal, | |||
| /// Reserve liquidity cumulative borrow rate | |||
| pub cumulative_borrow_rate_wads: Decimal, | |||
| /// Reserve accumulated protocol fees | |||
| pub accumulated_protocol_fees_wads: Decimal, | |||
There was a problem hiding this comment.
can we use same term as above - cumulative_protocol_fees_wad
There was a problem hiding this comment.
it means something different though
| .try_add(Decimal::from(usdc_balance_after - usdc_balance_before)) | ||
| .unwrap(); | ||
|
|
||
| assert_eq!( |
There was a problem hiding this comment.
these first 6 assertions are interesting they assert that total supply and exchange rate dont change when claiming fees (which makes sense)
but utilization does (because we take from available liquidity and add to debt. this balances the accounting that occurs over time where borrowers were accumulating more debt than lenders were owed until fees are claimed
nope-finance
force-pushed
the
take_rate
branch
2 times, most recently
from
f97c337 to
dd8152e
Compare
|
#89 implements this instead |
when interest compounds some gets set aside as a protocol claimable fee
additionally there is a crank function which makes it possible to claim the fees (anyone can call but the fees always go to the reserve fee receiver)