Add function to deposit reserve liquidity and collateral #8
Conversation
| @@ -309,6 +309,30 @@ pub enum LendingInstruction { | |||
| /// The amount that is to be borrowed - u64::MAX for up to 100% of available liquidity | |||
| amount: u64, | |||
| }, | |||
|
|
|||
There was a problem hiding this comment.
TBH I'm not 100% sure what accounts I should be using here and if the ones here are correct.
There was a problem hiding this comment.
uhh you should be able to check this in the code side (this is just a comment)
let source_liquidity_info = next_account_info(account_info_iter)?;
let user_collateral_info = next_account_info(account_info_iter)?;
let reserve_info = next_account_info(account_info_iter)?;
let reserve_liquidity_supply_info = next_account_info(account_info_iter)?;
let reserve_collateral_mint_info = next_account_info(account_info_iter)?;
let lending_market_info = next_account_info(account_info_iter)?;
let lending_market_authority_info = next_account_info(account_info_iter)?;
let destination_collateral_info = next_account_info(account_info_iter)?;
let obligation_info = next_account_info(account_info_iter)?;
let obligation_owner_info = next_account_info(account_info_iter)?;
let user_transfer_authority_info = next_account_info(account_info_iter)?;
let clock = &Clock::from_account_info(next_account_info(account_info_iter)?)?;
let token_program_id = next_account_info(account_info_iter)?;
so it looks fine at first glance
| @@ -543,6 +571,10 @@ impl LendingInstruction { | |||
| buf.push(13); | |||
| buf.extend_from_slice(&amount.to_le_bytes()); | |||
| } | |||
| Self::DepositReserveLiquidityAndObligationCollateral { liquidity_amount } => { | |||
| buf.push(4); | |||
| let user_transfer_authority_info = next_account_info(account_info_iter)?; | ||
| let clock = &Clock::from_account_info(next_account_info(account_info_iter)?)?; | ||
| let token_program_id = next_account_info(account_info_iter)?; | ||
|
|
There was a problem hiding this comment.
are there no extra checks we should do here?
There was a problem hiding this comment.
I figured no, since all it's doing is calling two existing endpoints, all which do their own checks
There was a problem hiding this comment.
ah yeh kk sounds fine then. the only main thing is the 4 vs 14
so lgtm
| clock, | ||
| token_program_id, | ||
| )?; | ||
| _deposit_obligation_collateral( |
There was a problem hiding this comment.
maybe there is a check on like collateral amount we should do?
There was a problem hiding this comment.
The _deposit_obligation_collateral checks for nonzero collateral amount. Anything else? I suupose we can change it to a >0 check
DaSichuan
force-pushed
the
add_combined_fn
branch
4 times, most recently
from
f5f7eed to
9bbc75f
Compare
DaSichuan
force-pushed
the
add_combined_fn
branch
from
9bbc75f to
c60c518
Compare
Combines DepositReserveLiquidity and DepositObligationCollateral so that we can do it all in one transaction.
It seems to me like we can rewrite this to do fewer things, but maybe we can do that later.