Two Prices PR - #129
Merged
Merged
Conversation
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## v2_upcoming #129 +/- ##
==============================================
Coverage ? 82.88%
==============================================
Files ? 44
Lines ? 14809
Branches ? 0
==============================================
Hits ? 12275
Misses ? 2534
Partials ? 0 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
| /// Risk-adjusted upper bound market value of borrows. | ||
| /// ie sum(b.borrowed_amount * max(b.current_spot_price, b.smoothed_price) * b.borrow_weight for b in borrows) | ||
| pub borrowed_value_upper_bound: Decimal, | ||
| /// The maximum borrow value at the weighted average loan to value ratio using the minimum of |
Member
There was a problem hiding this comment.
the maximum borrow value using min of spot and smooth price times ltv of each asset
something closer to this?
| let remaining_borrow_value = obligation.remaining_borrow_value()?; | ||
| let remaining_borrow_value = obligation | ||
| .remaining_borrow_value() | ||
| .unwrap_or_else(|_| Decimal::zero()); |
Member
There was a problem hiding this comment.
this wil just error on the next line
0xripleys
marked this pull request as ready for review
February 24, 2023 21:01
0xripleys
force-pushed
the
0xripleys_two_prices
branch
from
February 24, 2023 21:24
7a0c9c2 to
f49ff13
Compare
0xripleys
changed the base branch from
0xripleys_borrow_coefficient
to
v2_upcoming
February 24, 2023 21:24
0xripleys
added a commit
to 0xripleys/solana-program-library
that referenced
this pull request
Mar 7, 2023
- Add a smoothed_market_price to Reserve that is used to limit borrows and withdraws in cases where smoothed price and spot price diverge. - allowed_borrow_value now uses the min(smoothed_market_price, current spot price) - new field on obligation called borrowed_value_upper_bound that uses max(smoothed_market_price, current spot price)
nope-finance
pushed a commit
that referenced
this pull request
Mar 28, 2023
* 0xripleys outflow limits (#125) Use a sliding window rate limiter to limit borrows and withdraws at the lending pool owner's discretion. * 0xripleys borrow coefficient (#127) Add a borrow weight to the Reserve * Two Prices PR (#129) - Add a smoothed_market_price to Reserve that is used to limit borrows and withdraws in cases where smoothed price and spot price diverge. - allowed_borrow_value now uses the min(smoothed_market_price, current spot price) - new field on obligation called borrowed_value_upper_bound that uses max(smoothed_market_price, current spot price) * audit nits * audit fixes pt 2 * disable rate limiter if window duration == 0 * cli changes for v2.0.1 (#133)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Main Changes
Affected instructions
Refresh Reserve
Refresh Obligation
Withdraw Obligation Collateral + Withdraw Obligation Collateral and Redeem Reserve Liquidity
Borrow Obligation Liquidity
Note that liquidations still using current spot prices and have no dependence on the new smoothed_price value or borrowed_value_upper_bound