0xripleys outflow limits #125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xripleys
commented
Jan 27, 2023
| @@ -659,7 +675,6 @@ fn process_redeem_reserve_collateral( | |||
| } | |||
| let token_program_id = next_account_info(account_info_iter)?; | |||
|
|
|||
| _refresh_reserve_interest(program_id, reserve_info, clock)?; | |||
There was a problem hiding this comment.
since the lending market rate limiter is denominated in usd, we need an up-to-date price so i removed this function call
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## v2_upcoming #125 +/- ##
===============================================
+ Coverage 79.94% 80.86% +0.91%
===============================================
Files 40 42 +2
Lines 12712 13373 +661
===============================================
+ Hits 10163 10814 +651
- Misses 2549 2559 +10
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
| let market_value = reserve | ||
| .liquidity | ||
| .market_price | ||
| .try_mul(Decimal::from(liquidity_amount))?; |
There was a problem hiding this comment.
try_div(10**reserve.liquidity.mint_decimals)
There was a problem hiding this comment.
maybe call it redemption_value
| let market_value = borrow_reserve | ||
| .liquidity | ||
| .market_price | ||
| .try_mul(borrow_amount)?; |
| @@ -695,6 +702,10 @@ pub struct ReserveConfig { | |||
| pub protocol_liquidation_fee: u8, | |||
| /// Protocol take rate is the amount borrowed interest protocol recieves, as a percentage | |||
| pub protocol_take_rate: u8, | |||
| /// Rate limiter window size in slots | |||
| pub window_duration: u64, | |||
| @@ -1477,6 +1520,37 @@ fn process_borrow_obligation_liquidity( | |||
|
|
|||
| let cumulative_borrow_rate_wads = borrow_reserve.liquidity.cumulative_borrow_rate_wads; | |||
|
|
|||
| // check outflow rate limits | |||
| { | |||
| let borrow_value = borrow_reserve | |||
There was a problem hiding this comment.
maybe make borrow_reserve.market_value(liquidity_amount) method
|
|
||
| // assume the prev_window's outflow is even distributed across the window | ||
| // this isn't true, but it's a good enough approximation | ||
| let prev_weight = Decimal::one().try_sub( |
There was a problem hiding this comment.
let prev_weight = Decimal::from(self.config.window_duration).try_sub(Decimal::from(cur_slot - self.window_start + 1)).try_div(self.config.window_duration)
token-lending/sdk/src/instruction.rs
Outdated
| @@ -690,9 +709,11 @@ impl LendingInstruction { | |||
| buf.extend_from_slice(owner.as_ref()); | |||
| buf.extend_from_slice(quote_currency.as_ref()); | |||
| } | |||
| Self::SetLendingMarketOwner { new_owner } => { | |||
| Self::SetLendingMarketOwnerAndConfig { new_owner, config } => { | |||
0xripleys
added a commit
to 0xripleys/solana-program-library
that referenced
this pull request
Mar 7, 2023
Use a sliding window rate limiter to limit borrows and withdraws at the lending pool owner's discretion.
nope-finance
pushed a commit
that referenced
this pull request
Mar 28, 2023
* 0xripleys outflow limits (#125) Use a sliding window rate limiter to limit borrows and withdraws at the lending pool owner's discretion. * 0xripleys borrow coefficient (#127) Add a borrow weight to the Reserve * Two Prices PR (#129) - Add a smoothed_market_price to Reserve that is used to limit borrows and withdraws in cases where smoothed price and spot price diverge. - allowed_borrow_value now uses the min(smoothed_market_price, current spot price) - new field on obligation called borrowed_value_upper_bound that uses max(smoothed_market_price, current spot price) * audit nits * audit fixes pt 2 * disable rate limiter if window duration == 0 * cli changes for v2.0.1 (#133)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On any borrow or redeem instruction, we now check that the quantity outflowing doesn't exceed some specified amount per time.
Main Changes:
Other comments: