forked from solana-labs/solana-program-library
-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use pyth sdk + tests #113
Merged
Merged
Use pyth sdk + tests #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xripleys
changed the title
0xripleys use pyth client and allow grabbing a slightly stale pyth price
use pyth client and allow grabbing a slightly stale pyth price
Nov 21, 2022
0xripleys
commented
Nov 21, 2022
0xripleys
commented
Nov 22, 2022
0xripleys
changed the title
use pyth client and allow grabbing a slightly stale pyth price
Use pyth sdk + tests
Nov 23, 2022
ali-bahjati
reviewed
Nov 23, 2022
ali-bahjati
reviewed
Nov 23, 2022
Codecov Report
@@ Coverage Diff @@
## upcoming #113 +/- ##
============================================
+ Coverage 78.83% 79.35% +0.51%
============================================
Files 34 35 +1
Lines 9021 9115 +94
============================================
+ Hits 7112 7233 +121
+ Misses 1909 1882 -27
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
0xripleys
commented
Nov 28, 2022
0xripleys
commented
Nov 28, 2022
vs x86 or whatever)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
get_price_no_older_than
(link). This lets us use the pyth price even if pyth hasn't updated in the last 2 minutes.get_pyth_price
functionpartially addresses #111