Skip to content

Add fallback logic for sha checksum #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 10, 2024

Conversation

febo
Copy link
Contributor

@febo febo commented Mar 10, 2024

Not all systems have sha256sum by default (e.g., macOS), so this PR adds a fallback option to look for shasum. Additionally, it does not fail even if no checksum program is found and prints a warning instead.

Copy link

changeset-bot bot commented Mar 10, 2024

🦋 Changeset detected

Latest commit: 9d663f2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
create-solana-program Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Member

@lorisleiva lorisleiva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

I know why tests are failing and its not because of this PR. I changed the required dependencies generated by Kinobi so I'll fix that on main and then the tests should pass in this PR.

@lorisleiva lorisleiva merged commit 5a7ff73 into solana-program:main Mar 10, 2024
@github-actions github-actions bot mentioned this pull request Mar 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants