Calculate distance between u64 without overflow #9592
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #9592 +/- ##
========================================
- Coverage 80.6% 80.6% -0.1%
========================================
Files 279 279
Lines 63564 63578 +14
========================================
+ Hits 51245 51253 +8
- Misses 12319 12325 +6 |
carllin
reviewed
Apr 20, 2020
| @@ -412,11 +412,19 @@ pub fn broadcast_shreds( | |||
| Ok(()) | |||
| } | |||
|
|
|||
| fn distance(a: u64, b: u64) -> u64 { | |||
There was a problem hiding this comment.
Can we call this abs for absolute value? (same name as std::num crate)
carllin
approved these changes
Apr 20, 2020
mergify bot
pushed a commit
that referenced
this pull request
Apr 20, 2020
* fix overflow * fixed num_live_peers overflow (cherry picked from commit 77fb423) # Conflicts: # core/src/broadcast_stage.rs
mergify bot
pushed a commit
that referenced
this pull request
Apr 20, 2020
* fix overflow * fixed num_live_peers overflow (cherry picked from commit 77fb423)
solana-grimes
pushed a commit
that referenced
this pull request
Apr 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
u64 unchecked subtract
Summary of Changes
calculate a numerical distance instead
Fixes #9590