-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Calculate account refs fix #9447
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sakridge
force-pushed
the
account-refs-fix
branch
from
April 11, 2020 05:06
f085c3d
to
e105ff2
Compare
Codecov Report
@@ Coverage Diff @@
## master #9447 +/- ##
======================================
Coverage 81.1% 81.2%
======================================
Files 277 277
Lines 62319 62383 +64
======================================
+ Hits 50584 50670 +86
+ Misses 11735 11713 -22 |
ryoqun
reviewed
Apr 11, 2020
ryoqun
reviewed
Apr 11, 2020
ryoqun
reviewed
Apr 11, 2020
ryoqun
reviewed
Apr 11, 2020
ryoqun
reviewed
Apr 11, 2020
sakridge
force-pushed
the
account-refs-fix
branch
3 times, most recently
from
April 11, 2020 17:12
ed4a92d
to
417a323
Compare
sakridge
force-pushed
the
account-refs-fix
branch
from
April 11, 2020 18:31
417a323
to
0558a79
Compare
mergify bot
pushed a commit
that referenced
this pull request
Apr 11, 2020
(cherry picked from commit 9965520)
solana-grimes
pushed a commit
that referenced
this pull request
Apr 11, 2020
This was referenced Jan 1, 2024
This was referenced Mar 16, 2024
This was referenced Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
cleanup function does not handle cascading deletes
Summary of Changes
Use recursive dependency calculation to prevent premature deletes.
Fixes #9431