Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calculate account refs fix #9447

Merged
merged 1 commit into from
Apr 11, 2020
Merged

Conversation

sakridge
Copy link
Member

Problem

cleanup function does not handle cascading deletes

Summary of Changes

Use recursive dependency calculation to prevent premature deletes.

Fixes #9431

@codecov
Copy link

codecov bot commented Apr 11, 2020

Codecov Report

Merging #9447 into master will increase coverage by 0.0%.
The diff coverage is 100.0%.

@@          Coverage Diff           @@
##           master   #9447   +/-   ##
======================================
  Coverage    81.1%   81.2%           
======================================
  Files         277     277           
  Lines       62319   62383   +64     
======================================
+ Hits        50584   50670   +86     
+ Misses      11735   11713   -22     

@sakridge sakridge requested a review from ryoqun April 11, 2020 14:57
runtime/src/accounts_db.rs Outdated Show resolved Hide resolved
runtime/src/accounts_db.rs Outdated Show resolved Hide resolved
runtime/src/accounts_db.rs Outdated Show resolved Hide resolved
runtime/src/accounts_db.rs Outdated Show resolved Hide resolved
runtime/src/accounts_db.rs Outdated Show resolved Hide resolved
@sakridge sakridge force-pushed the account-refs-fix branch 3 times, most recently from ed4a92d to 417a323 Compare April 11, 2020 17:12
@sakridge sakridge added the v1.1 label Apr 11, 2020
@sakridge sakridge merged commit 9965520 into solana-labs:master Apr 11, 2020
@sakridge sakridge deleted the account-refs-fix branch April 11, 2020 19:52
mergify bot pushed a commit that referenced this pull request Apr 11, 2020
(cherry picked from commit 9965520)
solana-grimes pushed a commit that referenced this pull request Apr 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bad snapshot created on warehouse mainnet-beta nodes running v1.0.14
2 participants