Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nit: describe the root program id #8621

Merged
merged 1 commit into from
Mar 4, 2020
Merged

Conversation

jackcmay
Copy link
Contributor

@jackcmay jackcmay commented Mar 4, 2020

Problem

The variable name described as being the "loader's id" when its always a program but may not be a loader

Summary of Changes

Refer to it as the root program where its the root of a chain of programs >= 1 long

For example: could be the stake program -> |, or could be the BPFLoader -> program -> |

Fixes #

@jackcmay jackcmay requested a review from jstarry March 4, 2020 08:06
@codecov
Copy link

codecov bot commented Mar 4, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@4f05f08). Click here to learn what that means.
The diff coverage is 100%.

@@           Coverage Diff            @@
##             master   #8621   +/-   ##
========================================
  Coverage          ?     80%           
========================================
  Files             ?     256           
  Lines             ?   55730           
  Branches          ?       0           
========================================
  Hits              ?   44605           
  Misses            ?   11125           
  Partials          ?       0

@jackcmay jackcmay merged commit 642720a into solana-labs:master Mar 4, 2020
@jackcmay jackcmay deleted the nit-naming branch March 4, 2020 16:55
This was referenced May 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants