This repository was archived by the owner on Jan 22, 2025. It is now read-only.
LoadedPrograms::extract() code cleanup and unit tests #31604
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #31604 +/- ##
=======================================
Coverage 81.3% 81.3%
=======================================
Files 733 733
Lines 206474 206508 +34
=======================================
+ Hits 167864 167912 +48
+ Misses 38610 38596 -14 |
Lichtso
approved these changes
May 12, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The code in
extract()API can use some cleanup and more unit tests.Summary of Changes
Moved some of the conditions and checks in a separate function. Added unit tests specific to the new function.
Fixes #