wallet airdrop: Fetch a new last_id to prevent DuplicateSignature errors during AccountInUse retries #2171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Move that to thin_client.rs? |
garious
reviewed
Dec 14, 2018
src/wallet.rs
Outdated
| @@ -783,15 +783,31 @@ fn request_and_confirm_airdrop( | |||
| }; | |||
| match status { | |||
| RpcSignatureStatus::AccountInUse => { | |||
| last_id = get_last_id(rpc_client)?; | |||
| // Fetch a new last_id, to prevent the retry from getting rejected as a | |||
There was a problem hiding this comment.
Why are you implementing a DuplicateSignature handler in the AccountInUse handler?
There was a problem hiding this comment.
I'm not. When AccountInUse happens, we need to fetch a new last_id to prevent DuplicateSignature on the next retry
|
Bah this is wrong. |
Can't unfortunately, as |
|
@garious this PR is fixed up now if you care to take another look. It's not fancy stuff though |
garious
approved these changes
Dec 14, 2018
willhickey
pushed a commit
that referenced
this pull request
Jul 22, 2024
Undo deprecation message edit
ruuda
referenced
this pull request
Jul 22, 2024
yihau
pushed a commit
to yihau/solana
that referenced
this pull request
Jul 24, 2024
…ana-labs#2171) Undo deprecation message edit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempts to fix the intermittent CI failure that occurred at https://buildkite.com/solana-labs/solana/builds/6169#ff62509f-f382-43a9-a886-538aff015182