Ensure bpf_c files exist to avoid accidental rebuilds as the tree changes #2143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like this drops |
CriesofCarrots
pushed a commit
to CriesofCarrots/solana
that referenced
this pull request
Jul 17, 2024
willhickey
pushed a commit
that referenced
this pull request
Jul 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minutes were getting added to the stable-perf CI job because bpf-loader (and thus all it's dependencies such as
src/, oof) was getting rebuilt unnecessarily multiple times due to an incorrectly specifiedcargo:rerun-if-changedthat was referencing a non-existent file.This PR fixes that reference (
noopc++.c=>noopc++.cc), and adds checks to ensure this won't happen again