This repository has been archived by the owner on Jan 22, 2025. It is now read-only.
Rewrite faucet with tokio v0.3 #14336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-nelson
reviewed
Dec 29, 2020
Codecov Report
@@ Coverage Diff @@
## master #14336 +/- ##
=========================================
- Coverage 80.4% 80.4% -0.1%
=========================================
Files 399 399
Lines 98349 98368 +19
=========================================
+ Hits 79137 79149 +12
- Misses 19212 19219 +7 |
CriesofCarrots
force-pushed
the
bump-faucet-tokio
branch
from
68daca2 to
d6380b3
Compare
CriesofCarrots
force-pushed
the
bump-faucet-tokio
branch
from
d6380b3 to
fbd0645
Compare
t-nelson
approved these changes
Dec 30, 2020
mvines
approved these changes
Dec 30, 2020
mergify bot
pushed a commit
that referenced
this pull request
Dec 30, 2020
* Rewrite faucet for contemporary tokio * Move away from framed decoder (cherry picked from commit d63dd95) # Conflicts: # faucet/Cargo.toml
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Faucet code still depends on tokio v0.1
Summary of Changes
Rewrite using tokio v0.3 to synchronize with the majority of the code base
Upgrading to tokio v1.0 will require bumping🎉bytesandtokio-utilas wellToward #10187