Skip to content
This repository was archived by the owner on Jan 22, 2025. It is now read-only.

chore: clippy fixes #13579

Closed
wants to merge 1 commit into from
Closed

chore: clippy fixes #13579

wants to merge 1 commit into from

Conversation

hrls
Copy link
Contributor

@hrls hrls commented Nov 13, 2020

Problem

Clippy warns sort on primitives.

Summary of Changes

A few oneliners.

@hrls hrls changed the title Chore/clippy fixes chore: clippy fixes Nov 13, 2020
mvines
mvines reviewed Nov 14, 2020
View reviewed changes
@mvines mvines added the CI Pull Request is ready to enter CI label Nov 15, 2020
@solana-grimes solana-grimes removed the CI Pull Request is ready to enter CI label Nov 15, 2020
@mvines
Copy link
Contributor

mvines commented Nov 15, 2020

Looks like some build failures. You should be able to reproduce by running ci/test-checks.sh

@stale
Copy link

stale bot commented Nov 22, 2020

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the stale [bot only] Added to stale content; results in auto-close after a week. label Nov 22, 2020
@hrls hrls closed this Nov 24, 2020
@hrls hrls deleted the chore/clippy-fixes branch November 24, 2020 16:35
@hrls hrls restored the chore/clippy-fixes branch November 24, 2020 16:36
@hrls
Copy link
Contributor Author

hrls commented Nov 24, 2020

refreshed

@hrls hrls reopened this Nov 24, 2020
@stale stale bot removed the stale [bot only] Added to stale content; results in auto-close after a week. label Nov 24, 2020
@mvines mvines added the CI Pull Request is ready to enter CI label Nov 24, 2020
@solana-grimes solana-grimes removed the CI Pull Request is ready to enter CI label Nov 24, 2020
@mvines
Copy link
Contributor

mvines commented Nov 24, 2020

@hrls - hey do you know when #[allow(clippy::rc_buffer)] was introduced, Rust 1.47?

@hrls
Copy link
Contributor Author

hrls commented Nov 24, 2020

@mvines hi, looks like 1.47 rust-lang/rust-clippy#6128

@mvines
Copy link
Contributor

mvines commented Nov 24, 2020

Ok darn. We're stuck on 1.46 right now. Would you mind removing those #![allow(clippy::rc_buffer)] for now, so we can get the rest of this PR landed

@stale
Copy link

stale bot commented Dec 1, 2020

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the stale [bot only] Added to stale content; results in auto-close after a week. label Dec 1, 2020
@quasiyoke
Copy link

@hrls Nice PR BTW. Please check your email, we can't connect for several months. Sorry for offtop, guys.

@stale stale bot removed the stale [bot only] Added to stale content; results in auto-close after a week. label Dec 3, 2020
@stale
Copy link

stale bot commented Dec 11, 2020

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the stale [bot only] Added to stale content; results in auto-close after a week. label Dec 11, 2020
@mvines
Copy link
Contributor

mvines commented Dec 14, 2020

Thanks for the work here @hrls! I've rolled it into #14100, it certainly saved me some time

@stale stale bot removed the stale [bot only] Added to stale content; results in auto-close after a week. label Dec 14, 2020
@mvines mvines closed this Dec 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mvines mvines mvines left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hrls @mvines @quasiyoke @solana-grimes