Revert "Gossip PullRequests tend to return a lot of duplicates. (#103… #10455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…na-labs#10326)" This reverts commit 31e20ef.
|
Weird, do the overall replay times also look significantly worse (look at the "Time Spent in ReplayStage" dashboard, the |
carllin
approved these changes
Jun 8, 2020
Codecov Report
@@ Coverage Diff @@
## master #10455 +/- ##
=========================================
- Coverage 81.6% 81.6% -0.1%
=========================================
Files 296 296
Lines 69360 69321 -39
=========================================
- Hits 56633 56597 -36
+ Misses 12727 12724 -3 |
solana-grimes
pushed a commit
that referenced
this pull request
Jun 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…26)"
This reverts commit 31e20ef.
Problem
Makes confirmation times 2x slower.
Summary of Changes
Revert
Fixes #