More cluster stats and add epoch stakes cache in retransmit stage #10345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sakridge
changed the title
Codecov Report
@@ Coverage Diff @@
## master #10345 +/- ##
=========================================
- Coverage 81.3% 81.2% -0.2%
=========================================
Files 288 288
Lines 66861 66917 +56
=========================================
- Hits 54403 54378 -25
- Misses 12458 12539 +81 |
aeyakovenko
approved these changes
Jun 1, 2020
solana-grimes
pushed a commit
that referenced
this pull request
Jun 5, 2020
sakridge
added a commit
to sakridge/solana
that referenced
this pull request
Jun 8, 2020
…lana-labs#10345) * More cluster info metrics for push request/response counts * Cache staked peers for the epoch (cherry picked from commit ef37b82)
sakridge
added a commit
that referenced
this pull request
Jun 9, 2020
* Skip gossip requests with different shred version and split lock (#10240) (cherry picked from commit 3f508b3) * More cluster stats and add epoch stakes cache in retransmit stage (#10345) * More cluster info metrics for push request/response counts * Cache staked peers for the epoch (cherry picked from commit ef37b82) * Cache tvu peers for broadcast (#10373) (cherry picked from commit 2cf719a) * Add pull request count metrics (#10421) (cherry picked from commit 3d2230f)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Computing epoch stakes can take a long time in retransmit and hog the gossip lock to do duplicate work in multiple threads.
Incomplete metrics for number of packets received/sent in process push requests.
Summary of Changes
Cache the stake information for the epoch and the peer information for a second and only update with 1 thread. retransmit computation goes from ~500ms to less than 10ms.
Add more cluster_info metrics to see picture of all packets into and out of gossip.
Fixes #