Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove supply from Token #82

Merged
merged 1 commit into from
Jul 7, 2020
Merged

Conversation

jackcmay
Copy link
Contributor

@jackcmay jackcmay commented Jul 7, 2020

  • Tracking total supply may be misinterpreted and lead to confusion If accounts are removed due to rent delinquency.
  • Removing supply reduces a required key in the Burn instruction

@jstarry
Copy link
Member

jstarry commented Jul 7, 2020

If the pool is measured solely on token a, then I think fees could only accumulate in token b's balance

@jackcmay
Copy link
Contributor Author

jackcmay commented Jul 7, 2020 via email

@jstarry
Copy link
Member

jstarry commented Jul 7, 2020

Hehe, I'm just catching up to all the awesome work you've been doing!

@jackcmay
Copy link
Contributor Author

jackcmay commented Jul 7, 2020

Looks like the swap math might be off and I don't think token-swap needs supply, there are other ways to track it (like swap tracks it itself). More work to do on token-swap. Any objections to removing supply from the Token program?

@jackcmay jackcmay merged commit 56dd582 into solana-labs:master Jul 7, 2020
@jackcmay jackcmay deleted the remove-supply branch July 7, 2020 21:34
andrewsource147 pushed a commit to MeteoraAg/solana-program-library that referenced this pull request May 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants