Confidential mint burn extension: Token program changes #7319

abcalphabet · 2024-10-01T19:46:50Z

PR separating out only the token program changes from #6881 6881

samkim-crypto

Looks good to me overall! Many of the comments below are minor stylistic suggestions for consistency with the rest of the code base. There have also been some changes to how we deal with proof accounts after your original PR was made, so I made some comments regarding that (I apologize for this 🙏 ). Let me know what you think!

token/program-2022/src/extension/confidential_mint_burn/mod.rs

token/program-2022/src/extension/confidential_mint_burn/instruction.rs

token/program-2022/src/extension/confidential_mint_burn/verify_proof.rs

token/program-2022/src/extension/mod.rs

token/program-2022/src/extension/confidential_transfer/processor.rs

token/confidential-transfer/proof-generation/src/mint.rs

Co-authored-by: samkim-crypto <skim13@cs.stanford.edu>

…ction.rs Co-authored-by: samkim-crypto <skim13@cs.stanford.edu>

samkim-crypto

Looking really good, thanks 🙏 ! Just some comments on some things that I missed on my first pass and also things that have not yet resolved from the previous reviews.

token/confidential-transfer/proof-generation/src/supply.rs

token/confidential-transfer/proof-generation/src/mint.rs

token/program-2022/src/extension/confidential_mint_burn/instruction.rs

joncinque

Thanks for your contribution! Mostly small things, and I might have misunderstood some bits, so feel free to ignore things that don't correspond to your discussions with Sam.

libraries/pod/src/optional_keys.rs

token/program-2022/src/extension/confidential_mint_burn/instruction.rs

token/program-2022/src/extension/confidential_mint_burn/processor.rs

token/program-2022/src/serialization.rs

token/program-2022/src/extension/confidential_mint_burn/instruction.rs

Co-authored-by: Jon C <me@jonc.dev>

…ction.rs Co-authored-by: Jon C <me@jonc.dev>

…t_info.rs Co-authored-by: Jon C <me@jonc.dev>

joncinque

Thanks for integrating all the feedback! This is looking very close to me, just a few more bits

token/program-2022/src/processor.rs

token/program-2022/src/extension/confidential_mint_burn/instruction.rs

token/program-2022/src/extension/confidential_mint_burn/processor.rs

token/program-2022/src/serialization.rs

joncinque

Just a few last little bits from me, then this should be ready to go from my side! Thanks for your patience

token/program-2022/src/extension/confidential_mint_burn/processor.rs

token/program-2022/src/processor.rs

joncinque

This looks good to me! I'll @samkim-crypto give the final approval and merge

samkim-crypto

Thanks so much for your contribution and patience throughout! Everything looks fine on my side. Let's add tests for the extension to program-2022-test in a follow-up PR to be extra sure! I'll merge this one once CI passes.

abcalphabet added 20 commits June 19, 2024 10:34

confidential mint-burn extension

8fbb0fb

Merge branch 'master' into confidential_mint_burn_ext

de3d227

add ciphertext validity proof to confidential mint

32d528e

simplify burn proofs

3a9318d

add confidential supply

fee8acb

remove debug statements

5bbafec

add tests for confidential mint-burn

d6724a0

Merge branch 'master' into confidential_mint_burn_ext

0ec8537

fix clippy & serde tests

5939b72

Merge branch 'master' into confidential_mint_burn_ext

d4ad146

fix some tests

8479bad

Merge branch 'master' into confidential_mint_burn_ext

96d8f92

clippy

0b20da3

Merge branch 'master' into confidential_mint_burn_ext

48fcb02

mint burn with new proof generation

18aa58d

remove old mintburn proof generation

59234ba

cleanup

89c7cd2

remove cli / client changes and mint-burn tests

d46407c

cleanup

3944195

more cleanup

e010003

mergify bot added the community Community contribution label Oct 1, 2024

abcalphabet mentioned this pull request Oct 1, 2024

Confidential mint-burn extension #6881

Open

samkim-crypto self-requested a review October 2, 2024 03:15

fix clippy; serde logic

42e0193

samkim-crypto reviewed Oct 4, 2024

View reviewed changes

abcalphabet and others added 5 commits October 4, 2024 12:10

Update token/program-2022/src/extension/confidential_mint_burn/mod.rs

e0aefa2

Co-authored-by: samkim-crypto <skim13@cs.stanford.edu>

Update token/program-2022/src/extension/confidential_mint_burn/instru…

f795a3f

…ction.rs Co-authored-by: samkim-crypto <skim13@cs.stanford.edu>

review fixes

c2ec29a

refactor proof location processing

2a1316f

comment

3908688

cleanup

57684cf

samkim-crypto self-requested a review October 5, 2024 00:04

fix target_os=solana ; test-sbf

32e06db

samkim-crypto reviewed Oct 7, 2024

View reviewed changes

samkim-crypto self-requested a review October 7, 2024 09:37

abcalphabet added 3 commits October 7, 2024 17:44

review fixes

4fea36d

fix fmt / serde

3a14e2e

construct supply account info from ref to extension

8ad746e

samkim-crypto requested a review from joncinque October 8, 2024 21:42

abcalphabet added 2 commits October 9, 2024 09:42

add conf mint/burn failure docs; remove todo

df6cd8b

remove obsolete null check

20c84b5

joncinque reviewed Oct 17, 2024

View reviewed changes

abcalphabet and others added 5 commits October 24, 2024 16:19

Update token/program-2022/src/error.rs

bcc0812

Co-authored-by: Jon C <me@jonc.dev>

Update token/program-2022/src/extension/confidential_mint_burn/instru…

1d2b804

…ction.rs Co-authored-by: Jon C <me@jonc.dev>

Update token/program-2022/src/extension/confidential_mint_burn/accoun…

534861e

…t_info.rs Co-authored-by: Jon C <me@jonc.dev>

review fixes

b01ac24

Merge branch 'master' into confidential_mint_burn_ext_program

f601fdd

joncinque reviewed Oct 25, 2024

View reviewed changes

abcalphabet added 2 commits October 28, 2024 18:10

more fixes

5256e9d

Merge branch 'master' into confidential_mint_burn_ext_program

3f3c66e

joncinque reviewed Oct 29, 2024

View reviewed changes

abcalphabet added 2 commits October 29, 2024 08:25

clippy; review fixes

fbff190

Merge branch 'master' into confidential_mint_burn_ext_program

d46193f

joncinque approved these changes Oct 30, 2024

View reviewed changes

samkim-crypto approved these changes Oct 31, 2024

View reviewed changes

samkim-crypto merged commit 29eae22 into solana-labs:master Oct 31, 2024
35 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Confidential mint burn extension: Token program changes #7319

Confidential mint burn extension: Token program changes #7319

abcalphabet commented Oct 1, 2024

samkim-crypto left a comment

samkim-crypto left a comment

joncinque left a comment

joncinque left a comment

joncinque left a comment

joncinque left a comment

samkim-crypto left a comment •

edited

Loading

Confidential mint burn extension: Token program changes #7319

Confidential mint burn extension: Token program changes #7319

Conversation

abcalphabet commented Oct 1, 2024

samkim-crypto left a comment

Choose a reason for hiding this comment

samkim-crypto left a comment

Choose a reason for hiding this comment

joncinque left a comment

Choose a reason for hiding this comment

joncinque left a comment

Choose a reason for hiding this comment

joncinque left a comment

Choose a reason for hiding this comment

joncinque left a comment

Choose a reason for hiding this comment

samkim-crypto left a comment • edited Loading

Choose a reason for hiding this comment

samkim-crypto left a comment •

edited

Loading