Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version solana-sdk-bpf-test and spl-memo for crates.io #73

Merged
merged 1 commit into from
Jul 1, 2020

Conversation

CriesofCarrots
Copy link
Contributor

@CriesofCarrots CriesofCarrots commented Jul 1, 2020

Cargo.toml changes to enable cargo publish

@mvines @jackcmay While the program itself hasn't changed, do you think I should go all the way and change the program id and republish to the clusters, since this is a version number change?

@CriesofCarrots CriesofCarrots requested a review from jackcmay July 1, 2020 15:59
@mvines
Copy link
Member

mvines commented Jul 1, 2020

@mvines @jackcmay While the program itself hasn't change, do you think I should go all the way and change the program id and republish to the clusters, since this is a version number change?

IMO, no. We'd only need to republish redeploy if there are changes to the on-chain program

@CriesofCarrots
Copy link
Contributor Author

I'm going to wait and rebase this on #74 , since the spl-memo CI technically didn't run.

@CriesofCarrots CriesofCarrots merged commit 6e6f3c8 into solana-labs:master Jul 1, 2020
@CriesofCarrots CriesofCarrots deleted the bump-memo branch September 24, 2020 19:22
andrewsource147 pushed a commit to MeteoraAg/solana-program-library that referenced this pull request May 20, 2022
* adding switchboard v2 support

* made a test that relied on switchboard v2

* implemented some of justins feedback
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants