This repository was archived by the owner on Mar 11, 2025. It is now read-only.
[token-client] Make close_context_state_account and close_record_account variable order consistent
#7174
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joncinque
previously approved these changes
Aug 21, 2024
…ransfer_close_context_state_account`
…ority` in `confidential_transfer_close_record_account`
samkim-crypto
force-pushed
the
token-client/close-context
branch
from
5ed8c29 to
b475fed
Compare
mergify
bot
dismissed
joncinque’s stale review
Pull request has been modified.
joncinque
approved these changes
Aug 21, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
There is an inconsistency in the parameter orders between the
confidential_transfer_close_context_stateandconfidential_transfer_close_record_accountfunctions.confidential_transfer_close_context_state, the lamport destination account is before the context state authorityconfidential_transfer_close_record_account, the lamport destination comes after the context state authoritySummary of Changes
I updated
confidential_transfer_close_record_accountfunction to follow theconfidential_transfer_close_context_statefunction. I also updated theconfidential_transfer_close_context_statefunction name toconfidential_transfer_close_context_state_accountto be more consistent with the other functions.