New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

send socket.io event delete from a mongo event instead of after sending a delete request #18

Open

emmanuelgeoffray opened this issue Jul 7, 2017 · 0 comments

Member

emmanuelgeoffray commented Jul 7, 2017

To remove duplicate code :
spacebroClient.emit('media-deleted', {mediaId: media._id, bucketId: media.bucketId})
from
https://github.com/soixantecircuits/media-manager/blob/master/src/helpers/utils.js#L101
https://github.com/soixantecircuits/media-manager/blob/master/src/helpers/utils.js#L117

Also, the current implementation can be error prone, if there is another function to remove data.

The text was updated successfully, but these errors were encountered:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment