[MPT-13329] Added catalog listings endpoints #44
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robcsegal
requested review from
albertsola,
alephsur,
d3rky,
jentyk,
ruben-sebrango and
svazquezco
as code owners
svazquezco
reviewed
Sep 23, 2025
svazquezco
approved these changes
Sep 23, 2025
d3rky
requested changes
Sep 23, 2025
setup.cfg
Outdated
| mpt_api_client/resources/catalog/authorizations.py: WPS215 | ||
| mpt_api_client/resources/catalog/products.py: WPS204 WPS214 WPS215 | ||
| mpt_api_client/resources/catalog/items.py: WPS215 | ||
| mpt_api_client/resources/catalog/listings.py: WPS215 |
Contributor
There was a problem hiding this comment.
most probably this exception is going to be everywhere in catalog files... Maybe you can squash it to
mpt_api_client/resources/catalog/*.py: WPS215
Contributor
Author
There was a problem hiding this comment.
most probably this exception is going to be everywhere in catalog files... Maybe you can squash it to
mpt_api_client/resources/catalog/*.py: WPS215
updated setup.cfg
robcsegal
force-pushed
the
MPT-13329-add-catalog-listings
branch
from
0ea3d71 to
41af02e
Compare
d3rky
requested changes
Sep 23, 2025
setup.cfg
Outdated
| mpt_api_client/resources/catalog/product_terms.py: WPS215 | ||
| mpt_api_client/resources/catalog/product_term_variants.py: WPS215 | ||
| mpt_api_client/resources/commerce/agreements_attachments.py: WPS215 | ||
| mpt_api_client/resources/catalog/price_lists.py: WPS110 WPS215 |
Contributor
There was a problem hiding this comment.
I think you can add both to line 35 :-)
Contributor
Author
There was a problem hiding this comment.
I think you can add both to line 35 :-)
i updated setup.cfg to include both
robcsegal
force-pushed
the
MPT-13329-add-catalog-listings
branch
from
41af02e to
b625283
Compare
|
d3rky
approved these changes
Sep 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added catalog listings endpoints
https://softwareone.atlassian.net/browse/MPT-13329