MPT-12845 Add Commerce subscriptions #25
Conversation
albertsola
requested review from
alephsur,
d3rky,
jentyk,
robcsegal,
ruben-sebrango and
svazquezco
as code owners
| assert isinstance(orders_service_additional, AsyncOrdersService) | ||
|
|
||
|
|
||
| def test_async_subscriptions(async_http_client: AsyncHTTPClient): |
There was a problem hiding this comment.
I'd like to parametrize the orders_properties tests. Otherwise, please, use the same name as we have for orders -> ...commerce_orders_property..., ...commerce_subscriptions_property....
| ).mock( | ||
| return_value=httpx.Response( | ||
| status_code=httpx.codes.OK, | ||
| json=subscription_expected, |
There was a problem hiding this comment.
Please remove the comma to avoid splitting the line unnecessarily
There was a problem hiding this comment.
ruff seems to add it if the line does not fit inside a single line in this case
| ).mock( | ||
| return_value=httpx.Response( | ||
| status_code=httpx.codes.OK, | ||
| json=subscription_expected, |
There was a problem hiding this comment.
Same comment about the comma here
There was a problem hiding this comment.
ruff seems to add it if the line does not fit inside a single line in this case
albertsola
force-pushed
the
MPT-12845/Commerce-subscriptions
branch
from
256905e to
2e4344a
Compare
albertsola
force-pushed
the
MPT-12845/Commerce-subscriptions
branch
from
2e4344a to
ee28092
Compare
|
No description provided.