fix: deprecate unused fontData prop #2753
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakex7
approved these changes
Nov 5, 2025
jakex7
requested changes
Nov 5, 2025
Member
jakex7
left a comment
jakex7
left a comment
There was a problem hiding this comment.
Actually, we may want to deprecate it instead
kacperzolkiewski
force-pushed
the
fixFontDataProp
branch
from
a2546cf to
7e9becc
Compare
kacperzolkiewski
changed the title
jakex7
approved these changes
Nov 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes: #2478
The
fontDataproperty was created for internal usage within the library and was never intended to be exposed or used by external users. PR deprecate this prop to avoid confusion and ensure the public API remains clean and aligned with SVG standards.Test Plan
Run example from issue: #2478, you should see a warning:
Compatibility
Checklist
README.md__tests__folder