feat(Android): Add support for different Top App Bar styles #1874
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sition of screens even better
tboba
force-pushed
the
@tboba/introduce-material3-finally-prettier-android-ui
branch
from
b4b31b9
to
cf32cbc
Compare
… CollapsingToolbarLayout
…`headerTopInsetEnabled` to false
…top, fix positioning of header items
…terial 3 into app
tboba
requested review from
WoLewicki and
kkafar
and removed request for
WoLewicki,
kacperkapusciak and
kkafar
WoLewicki
reviewed
Feb 5, 2024
android/src/main/java/com/swmansion/rnscreens/ScreenStackFragment.kt
Outdated
Show resolved
Hide resolved
android/src/main/java/com/swmansion/rnscreens/ScreenStackFragment.kt
Outdated
Show resolved
Hide resolved
| // Reattach the header, when the developer tries to change the header type | ||
| if (screenStackHeader?.loadedHeaderType != screen?.headerType) { | ||
| screenStackHeader?.updateHeaderType() | ||
| screenFragment?.removeToolbar() |
There was a problem hiding this comment.
That's because of updating the layoutParams of appBarLayout. Basically, when we're changing the type of appBar, its layout is being changed, resulting in wrong position of the views. For that reason we're removing all of its views (they will be added further in onUpdate) and setting references of toolbar and collapsingtoolbarlayout to null to ensure that we won't use old toolbars
|
This is very exciting! Awesome work! |
|
Currently, this PR is blocked by changes from facebook/react-native#44099 (we may skip requiring setting the prop |
|
That could make sense! We already set |
tboba
changed the title
tboba
changed the title
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Since the beginning of time...
Since the first version of react-native-screens...
There was a toolbar.
But toolbar have always been...
Small and non-expandable...
Nowadays...
times have changed.
This Pull Request introduces not 3, not 3.5, but 4 types of headers -
center-aligned,small,mediumandlargeheader types, where the last two of them can collapse.From now the toolbar will always be nested in
CollapsingToolbarLayout, but this shouldn't have an impact on the experience overall.Unfortunately, while having header type set to
mediumorlargetheheaderCenterproperty does not work for now.For the best experience of using new header types it is recommended to have Material 3 bundled into the application, while using new header types.
For more information about the header types, please visit official Material 3 documentation.
Changes
headerLeftandheaderRightprop)Screenshots / GIFs
Before
Screen.Recording.2023-09-01.at.17.22.13.mov
After
8mb.video-WMw-Zz1dZmWl.mp4
Test code and steps to reproduce
Use
Test1874attached to this branch to test the changes inTestsExample&FabricTestExample.Checklist