Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

presentation: 'modal' Screens are tiny on iPad / iOS18 #2549

Open
jforaker opened this issue Dec 4, 2024 · 4 comments
Open

presentation: 'modal' Screens are tiny on iPad / iOS18 #2549

jforaker opened this issue Dec 4, 2024 · 4 comments
Assignees
Labels
Platform: iOS This issue is specific to iOS Repro provided A reproduction with a snack or repo is provided

Comments

@jforaker
Copy link

jforaker commented Dec 4, 2024

Description

Greetings.

(Firstly I'm always a little confused about who owns what in terms of react-navigation vs react-navite-screens so hopefully I'm in the right place. If I'm not please let me know!)

Ever since iOS 18 came out, our users have pointed that several screens now appear really tiny on IOS.

Note in the screenshot the screen titled "Adjust Study Weights" is a createNativeStackNavigator() screen pushed with presentation: 'modal' . I believe this to be a bug somewhere down the native screen chain, but its hard for me as an outsider to isolate the source.

"react-native-screens": "4.3.0"

Note this is reproducible in the Snack: https://snack.expo.dev/TrJplgYWOFa8TGOILcUb6 (You might have to choose IOS > "iPad Pro 12.9" manually)

image

side by side ios 17/18

image

Steps to reproduce

  1. make some screens using createNativeStackNavigator()
  2. use presentation: 'modal' and test on an iPad

Snack or a link to a repository

https://snack.expo.dev/O78qXxcUm1WbmoQuoTM9A

Screens version

4.3.0

React Native version

0.73.9

Platforms

iOS

JavaScript runtime

Hermes

Workflow

React Native (without Expo)

Architecture

Paper (Old Architecture)

Build type

Release mode

Device

iOS simulator

Device model

iPad Pro 13-inch (M4), iOS 18.0

Acknowledgements

Yes

@github-actions github-actions bot added Platform: iOS This issue is specific to iOS Repro provided A reproduction with a snack or repo is provided labels Dec 4, 2024
@kkafar
Copy link
Member

kkafar commented Dec 5, 2024

Unfortunately it seems that this is not a bug. This is change of behaviour introduced with iOS 18 & when I did research on it ~1.5 weeks ago I haven't found UIKit API to restore older behaviour. Apple added SwiftUI API (link) to allow to restore old behaviour, however I haven't found equivalent in UIKit. Right now I do not know what should be the way forward with this issue. I'm open for suggestions.

@kkafar kkafar self-assigned this Dec 5, 2024
@jforaker
Copy link
Author

jforaker commented Dec 5, 2024

Thanks @kkafar -- appreciate the reply. Sounds like we'll have to live with it for now. Its not the end of the world, but it is certainly a quirky decision from the IOS side.

Feel free to close this issue if you want.

@kkafar
Copy link
Member

kkafar commented Dec 6, 2024

I'm closing the issue yet, because I'm considering using PageSheet instead of Automatic UIPresentationStyle for the presentation: 'modal' prop, which might restore the old behaviour, but I'm yet unsure what other behaviour would change 😅 I'll test this once I tend to few other matters.

@jforaker
Copy link
Author

jforaker commented Dec 7, 2024

Cool. Sounds good @kkafar

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Platform: iOS This issue is specific to iOS Repro provided A reproduction with a snack or repo is provided
Projects
None yet
Development

No branches or pull requests

2 participants