-
-
Notifications
You must be signed in to change notification settings - Fork 588
Comparing changes
Open a pull request
base repository: software-mansion/react-native-screens
base: 4.8.0
head repository: software-mansion/react-native-screens
compare: 4.9.0
- 10 commits
- 70 files changed
- 4 contributors
Commits on Feb 19, 2025
-
feat: support for RN 0.78.0-rc.5 (#2626)
## Description Add library support for react-native 0.78 & use 0.78 in example apps. > [!caution] This PR breaks compatibility with older react native versions on new architecture. In case it is merged new architecture will be supported only from 0.78 onwards. The breaking change in core we need to follow: > > * facebook/react-native#48062 > > There are also breaking changes made in core regarding method / function signatures, see required adjustments here 5a7e440 > > **I believe these Android method signature changes do break backward compatibility also on old architecture!** ## Changes ## Test code and steps to reproduce <!-- Please include code that can be used to test this change and short description how this example should work. This snippet should be as minimal as possible and ready to be pasted into editor (don't exclude exports or remove "not important" parts of reproduction example) --> ## Checklist - [ ] Ensured that CI passes --------- Co-authored-by: Marc Rousavy <me@mrousavy.com>
Configuration menu - View commit details
-
Copy full SHA for 13384c9 - Browse repository at this point
Copy the full SHA 13384c9View commit details -
fix(Android,Paper): regenerate codegened files for old architecture (#…
…2715) ## Description Seems that these have changed. ## Changes Updated codegened files for old architecture by running `yarn sync-architectures`. > [!caution] I think that these changes also break compatibility on old architecture. ## Test code and steps to reproduce Let's see whether Paper build works now on CI... ## Checklist - [ ] Included code example that can be used to test this change - [ ] Ensured that CI passes
Configuration menu - View commit details
-
Copy full SHA for d93edfa - Browse repository at this point
Copy the full SHA d93edfaView commit details -
Configuration menu - View commit details
-
Copy full SHA for 901aa73 - Browse repository at this point
Copy the full SHA 901aa73View commit details
Commits on Feb 20, 2025
-
fix(iOS,Paper): fix false-negative lookup result for parent view from…
… content wrapper (#2719) ## Description Closes #2717 For some reason on old architecture, when calling `navigation.replace()` the replaced screen receives `willMoveToWindow:` message from UIKit with non-nil argument, defying my previous expectations. On new architecture this works as expected: removed screen receives `nil` window & we do not run the content-wrapper-attachment logic. ## Changes Error is logged only on new architecture now. ## Test code and steps to reproduce WIP ## Checklist - [x] Included code example that can be used to test this change - [ ] Ensured that CI passes
Configuration menu - View commit details
-
Copy full SHA for df7a7d1 - Browse repository at this point
Copy the full SHA df7a7d1View commit details -
refactor: detect fabric with RN$Bridgeless (#2722)
## Description Since 0.74 `RN$Bridgeless` is always defined in the global object and bridgeless mode isn't supported anymore. Therefore checking `RN$Bridgeless` for Fabric is safer than depending on `_IS_FABRIC` variable which we intend to remove in the future. `RN$Bridgeless` is added to `global` much faster than `_IS_FABRIC`. See software-mansion/react-native-reanimated#7043 ## Changes 👍 ## Screenshots / GIFs :shipit: ## Test code and steps to reproduce 🚀 ## Checklist - [x] Included code example that can be used to test this change - [x] Updated TS types - [x] Updated documentation: <!-- For adding new props to native-stack --> - [x] https://github.com/software-mansion/react-native-screens/blob/main/guides/GUIDE_FOR_LIBRARY_AUTHORS.md - [x] https://github.com/software-mansion/react-native-screens/blob/main/native-stack/README.md - [x] https://github.com/software-mansion/react-native-screens/blob/main/src/types.tsx - [x] https://github.com/software-mansion/react-native-screens/blob/main/src/native-stack/types.tsx - [x] Ensured that CI passes
Configuration menu - View commit details
-
Copy full SHA for 8bc0cc2 - Browse repository at this point
Copy the full SHA 8bc0cc2View commit details -
fix(Android): fix sheet transition when there is no dimming applied (#…
…2723) ## Description Shout out to @kligarski for spotting this out! I've introduced a regression in 4.7.0 when refactoring sheet animation - basically it always animated to the resolved `maxAlpha` for given sheet dimming view & did not take into account `sheetLargestUndimmedDetentIndex` prop, effectively disabling this prop. This affects both architectures. ## Changes When configuring enter animation we now take the prop into account. ## Test code and steps to reproduce `TestFormSheet` ## Checklist - [x] Included code example that can be used to test this change - [ ] Ensured that CI passes
Configuration menu - View commit details
-
Copy full SHA for 1540218 - Browse repository at this point
Copy the full SHA 1540218View commit details
Commits on Feb 21, 2025
-
Configuration menu - View commit details
-
Copy full SHA for 8f0975d - Browse repository at this point
Copy the full SHA 8f0975dView commit details -
chore: restore backward compat for new & old architecture (#2730)
## Description Restoring backward compatibility for old architecture - now we require 76. 75 could work, but I've not tested this. On new architecture we require 77. It should compile on 76, however we need the fix for the removal of transitioning views that landed in 77. See here: #2596. ## Changes Described mostly down below 👇🏻 in review comments. ## Checklist I've tested this manually on fresh RN 76 & 78 app, new/old architecture, iOS/Android. - [ ] Ensured that CI passes
Configuration menu - View commit details
-
Copy full SHA for b5a0f9f - Browse repository at this point
Copy the full SHA b5a0f9fView commit details -
chore(readme): update supported react-native versions (#2727)
## Description Updated the "supported version table" for 4.9.0 release. ## Changes Paper is supported for RN >= 0.76 Fabric is supported for RN == 78. ## Test code and steps to reproduce ## Checklist - [ ] Ensured that CI passes
Configuration menu - View commit details
-
Copy full SHA for b0291b1 - Browse repository at this point
Copy the full SHA b0291b1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3aea98a - Browse repository at this point
Copy the full SHA 3aea98aView commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff 4.8.0...4.9.0