Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: create symlink to common-app #6637

Merged
merged 2 commits into from
Oct 28, 2024
Merged

fix: create symlink to common-app #6637

merged 2 commits into from
Oct 28, 2024

Conversation

jakex7
Copy link
Member

@jakex7 jakex7 commented Oct 25, 2024

Summary

Similar to software-mansion/react-native-svg#2512, it fixes resolving local images on Android by creating a symlink to the common directory, allowing images to be resolved without the ../ segment.

Test plan

Run example app on Android and add

<Image source={require('./assets/doge.png')} />

in EmptyExample.tsx

@jakex7 jakex7 requested a review from tomekzaw October 25, 2024 19:11
tomekzaw
tomekzaw approved these changes Oct 28, 2024
View reviewed changes
Copy link
Member

@tomekzaw tomekzaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected. Thanks for the PR!

Screenshot 2024-10-28 at 16 53 41

@tomekzaw tomekzaw added this pull request to the merge queue Oct 28, 2024
Merged via the queue into main with commit 254a737 Oct 28, 2024
13 checks passed
@tomekzaw tomekzaw deleted the @jakex7/fixAndroidImages branch October 28, 2024 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomekzaw tomekzaw tomekzaw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jakex7 @tomekzaw