fix: Invalid shared value access displaying when code is correct #6631
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MatiPl01
commented
Oct 25, 2024
tjzel
reviewed
Oct 25, 2024
MatiPl01
deleted the
@matipl01/fix-invalid-shared-value-access-warning
branch
tjzel
pushed a commit
that referenced
this pull request
Nov 25, 2024
## Summary
The problem was caused by our `useDerivedValue` hook which set ref to
`null` in the `useEffect` cleanup method.
```tsx
useEffect(() => {
return () => {
initRef.current = null;
};
}, []);
```
The warning was shown during hot reload, because react calls cleanup
functions in hooks, thus the `initRef` was reset in the
`useDerivedValue` hook, which resulted in execution of this code that
should run only when the component mounts for the first time:
```tsx
if (initRef.current === null) {
initRef.current = makeMutable(initialUpdaterRun(updater));
}
```
Because of that, `initialUpdaterRun` executed the `updater` callback on
the JS thread during hot reload, while the component was rendered, which
resulted in reading shared value's `.value` property during the render
phase.
Merged
tjzel
pushed a commit
that referenced
this pull request
Nov 26, 2024
## Summary
The problem was caused by our `useDerivedValue` hook which set ref to
`null` in the `useEffect` cleanup method.
```tsx
useEffect(() => {
return () => {
initRef.current = null;
};
}, []);
```
The warning was shown during hot reload, because react calls cleanup
functions in hooks, thus the `initRef` was reset in the
`useDerivedValue` hook, which resulted in execution of this code that
should run only when the component mounts for the first time:
```tsx
if (initRef.current === null) {
initRef.current = makeMutable(initialUpdaterRun(updater));
}
```
Because of that, `initialUpdaterRun` executed the `updater` callback on
the JS thread during hot reload, while the component was rendered, which
resulted in reading shared value's `.value` property during the render
phase.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The problem was caused by our
useDerivedValuehook which set ref tonullin theuseEffectcleanup method.The warning was shown during hot reload, because react calls cleanup functions in hooks, thus the
initRefwas reset in theuseDerivedValuehook, which resulted in execution of this code that should run only when the component mounts for the first time:Because of that,
initialUpdaterRunexecuted theupdatercallback on the JS thread during hot reload, while the component was rendered, which resulted in reading shared value's.valueproperty during the render phase.