Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix spotless config #6349

Merged
merged 1 commit into from
Jul 30, 2024
Merged

Fix spotless config #6349

merged 1 commit into from
Jul 30, 2024

Conversation

tomekzaw
Copy link
Member

@tomekzaw tomekzaw commented Jul 30, 2024

Summary

We've noticed that sometimes Java files are not properly formatted but the CI is still green. The reason is that only src/main/java/**/*.java was formatted but there are still paper/, fabric/ and reactNativeVersionPatch/ directories that are not covered by this glob.

This PR extends the coverage of spotless formatter as well as formats the remaining files.

Test plan

@tomekzaw tomekzaw requested a review from piaskowyk July 30, 2024 07:44
@tomekzaw tomekzaw force-pushed the @tomekzaw/fix-spotless-config branch from 0b68f59 to 91f2aa0 Compare July 30, 2024 08:20
@tomekzaw tomekzaw added this pull request to the merge queue Jul 30, 2024
Merged via the queue into main with commit f60dadd Jul 30, 2024
15 checks passed
@tomekzaw tomekzaw deleted the @tomekzaw/fix-spotless-config branch July 30, 2024 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants