Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Web LA] Fix easing #6304

Merged
merged 5 commits into from
Jul 22, 2024
Merged

[Web LA] Fix easing #6304

merged 5 commits into from
Jul 22, 2024

Conversation

m-bert
Copy link
Contributor

@m-bert m-bert commented Jul 22, 2024

Summary

After #6163 was merged, each worklet function follows new naming convention. Since easings are worklets, their name property has also been changed. In web layout animations we were applying easing based on its name, therefore changing it resulted in only default linear easing being available on web.

This PR adds new Symbol into easing functions so that we can once again get their name and apply correct easing to animations.

Test plan

Tested on BasicLayoutAnimation example with Easing.exp

@m-bert m-bert requested review from tjzel and piaskowyk July 22, 2024 08:53
Copy link
Collaborator

@tjzel tjzel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pattern is still far from perfect but 🚀

@m-bert m-bert added this pull request to the merge queue Jul 22, 2024
Merged via the queue into main with commit a71d081 Jul 22, 2024
6 checks passed
@m-bert m-bert deleted the @mbert/fix-easing-on-web branch July 22, 2024 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants