Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify snapshots comparison #6295

Merged
merged 2 commits into from
Jul 26, 2024
Merged

Unify snapshots comparison #6295

merged 2 commits into from
Jul 26, 2024

Conversation

Latropos
Copy link
Contributor

@Latropos Latropos commented Jul 19, 2024

Summary

Unify code for snapshot comparison on Android and IOS.
Also a lot of outdated code was cleaned out, as we have decided not to return snapshots of multiple views, but always for a certain predefined one.

Test plan

@Latropos Latropos marked this pull request as ready for review July 23, 2024 09:59
Copy link
Member

@piaskowyk piaskowyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

@Latropos Latropos added this pull request to the merge queue Jul 26, 2024
Merged via the queue into main with commit 5c44da9 Jul 26, 2024
5 checks passed
@Latropos Latropos deleted the acynk/unify-snapshots branch July 26, 2024 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants