Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce file structure to tests #6293

Merged
merged 8 commits into from
Jul 18, 2024
Merged

Introduce file structure to tests #6293

merged 8 commits into from
Jul 18, 2024

Conversation

Latropos
Copy link
Contributor

@Latropos Latropos commented Jul 18, 2024 •
edited by github-actions bot
Loading

Summary

The new file structure is:

image

Test plan

@Latropos Latropos requested a review from piaskowyk July 18, 2024 12:13
@Latropos Latropos marked this pull request as ready for review July 18, 2024 12:13
@Latropos Latropos marked this pull request as draft July 18, 2024 12:46
piaskowyk
piaskowyk approved these changes Jul 18, 2024
View reviewed changes
Copy link
Member

@piaskowyk piaskowyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's generally okay, but using the name utils is not the best practice. Unfortunately, I don't have a better suggestion so we can use it 👍

@Latropos Latropos marked this pull request as ready for review July 18, 2024 13:37
Base automatically changed from acynk/rename-test-folder to main July 18, 2024 13:44
@Latropos Latropos added this pull request to the merge queue Jul 18, 2024
Merged via the queue into main with commit e179b6a Jul 18, 2024
5 checks passed
@Latropos Latropos deleted the acynk/introduce-file-structure branch July 18, 2024 14:00
@chaitanyapotti chaitanyapotti mentioned this pull request Aug 28, 2024
Open
@phucle1010 phucle1010 mentioned this pull request Aug 28, 2024
Open
@arenault-pass arenault-pass mentioned this pull request Aug 28, 2024
Closed
@jaydenchee97 jaydenchee97 mentioned this pull request Aug 28, 2024
Open
@azu-josh azu-josh mentioned this pull request Aug 28, 2024
Open
@phucle1010 phucle1010 mentioned this pull request Aug 29, 2024
Open
@Bonnie-TJ Bonnie-TJ mentioned this pull request Sep 4, 2024
Open
@tanyipeng834 tanyipeng834 mentioned this pull request Sep 4, 2024
Open
@arenault-pass arenault-pass mentioned this pull request Sep 6, 2024
Closed
@mhmoudmhmed mhmoudmhmed mentioned this pull request Sep 7, 2024
Open
This was referenced Sep 7, 2024
Closed
Closed
This was referenced Sep 24, 2024
Open
Open
@SanteriMertakorpi SanteriMertakorpi mentioned this pull request Sep 24, 2024
Open
This was referenced Sep 25, 2024
Closed
Closed
Closed
@ananichoumchoum ananichoumchoum mentioned this pull request Sep 27, 2024
Open
@arenault-pass arenault-pass mentioned this pull request Sep 28, 2024
Closed
@yingbull yingbull mentioned this pull request Sep 28, 2024
Closed
@manh20012000 manh20012000 mentioned this pull request Sep 29, 2024
Open
@Alaa-1074002 Alaa-1074002 mentioned this pull request Sep 29, 2024
Open
@manh20012000 manh20012000 mentioned this pull request Oct 1, 2024
Open
This was referenced Oct 1, 2024
Closed
Closed
@WontonSam WontonSam mentioned this pull request Oct 2, 2024
Open
@phucle1010 phucle1010 mentioned this pull request Oct 2, 2024
Open
This was referenced Oct 3, 2024
Closed
Closed
This was referenced Oct 4, 2024
Closed
Closed
This was referenced Oct 5, 2024
Closed
Closed
@phucle1010 phucle1010 mentioned this pull request Oct 25, 2024
Open
@kabir0x23 kabir0x23 mentioned this pull request Oct 28, 2024
Closed
@yingbull yingbull mentioned this pull request Oct 28, 2024
Closed
@phucle1010 phucle1010 mentioned this pull request Nov 1, 2024
Open
@Abyss0108 Abyss0108 mentioned this pull request Nov 3, 2024
Open
@kabir0x23 kabir0x23 mentioned this pull request Nov 4, 2024
Closed
@PoojaPanchal12 PoojaPanchal12 mentioned this pull request Nov 5, 2024
Open
@edwardsph edwardsph mentioned this pull request Nov 6, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@piaskowyk piaskowyk piaskowyk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Latropos @piaskowyk