-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Web LA] Add withInitialValues
modifier
#6254
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piaskowyk
approved these changes
Jul 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just change the logic responsible by opacity and you can merge it 👍
piaskowyk
approved these changes
Jul 15, 2024
This was referenced Sep 24, 2024
This was referenced Oct 1, 2024
This was referenced Oct 3, 2024
This was referenced Oct 4, 2024
This was referenced Oct 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds
withInitialValues
into web layout animations.Note
This implementation required #6259. You can find more information in mentioned PR.
Implementation
Implementation is based on modifying first step in
keyframe
. First we obtain default animation style and create its copy usingstructuredClone
. We also addpx
suffix intotranslate
andperspective
ininitialValues
. Then we can modify styles of animation.transform
Here situation is more complicated. First, if
transform
was not specified in the predefined styles, we can simply assign to it the one provided ininitialValues
. Otherwise we have to merge incoming transform with predefined one.To do this, we use
Map
that will contain finaltransform
. First we iterate through predefined transforms, adding each property with its value. Then we perform second iteration, this time ontransform
frominitialValues
. In that case we will either add new property, or override existing one. Finally we convertMap
back to array of objects usingArray.from
method.Other props
Since layout animations on web do not change other props directly, we can simply assign them into styles object.
Note
Animation that has
withInitialValues
modifier is treated like a custom animation and undergoes whole process of adding it intoDOM
and removing it when it finishes.Example
Animation code
Nagranie.z.ekranu.2024-07-11.o.16.27.21.mov
Test plan
Tested on the following code