Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve PerformanceMonitor's functionality #6241

Merged
merged 5 commits into from
Jul 15, 2024
Merged

Improve PerformanceMonitor's functionality #6241

merged 5 commits into from
Jul 15, 2024

Conversation

latekvo
Copy link
Contributor

@latekvo latekvo commented Jul 9, 2024 •
edited
Loading

Summary

PerformanceMonitor unnecessarily used accumulator and time delta calculations.
I replaced those with time range measurement and added component props to modify smoothing amount.

Additionally smoothing is now modifiable via the PerformanceMonitorProps,
which are exported alongside PerformanceMonitor

Test plan

Not consistently reproducible.

Issue videos:

exhibit 1 (smoothing=5) exhibit 2 exhibit 3
Screen.Recording.2024-07-09.at.11.21.25.mov
Screen.Recording.2024-07-09.at.10.55.31.mov
Screen.Recording.2024-07-09.at.10.34.47.mov

New code video:

Screen.Recording.2024-07-09.at.12.18.00.mov

Related

This PR is a simpler successor to this PR.

@latekvo latekvo changed the title Fix performance monitor fps leaks Improve PerformanceMonitor's functionality Jul 9, 2024
@latekvo latekvo marked this pull request as ready for review July 9, 2024 11:59
@latekvo latekvo requested review from piaskowyk and szydlovsky July 9, 2024 12:35
szydlovsky
szydlovsky approved these changes Jul 10, 2024
View reviewed changes
Copy link
Contributor

@szydlovsky szydlovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and much much simpler, I like it 😄

packages/react-native-reanimated/src/component/PerformanceMonitor.tsx Show resolved Hide resolved
piaskowyk
piaskowyk approved these changes Jul 15, 2024
View reviewed changes
Copy link
Member

@piaskowyk piaskowyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great 🎉

packages/react-native-reanimated/src/index.ts Outdated Show resolved Hide resolved
@latekvo latekvo added this pull request to the merge queue Jul 15, 2024
Merged via the queue into main with commit 527d9ef Jul 15, 2024
6 checks passed
@latekvo latekvo deleted the @latekvo/fix-performance-monitor-leaks branch July 15, 2024 09:29
@chaitanyapotti chaitanyapotti mentioned this pull request Aug 28, 2024
Open
@phucle1010 phucle1010 mentioned this pull request Aug 28, 2024
Open
@arenault-pass arenault-pass mentioned this pull request Aug 28, 2024
Closed
@jaydenchee97 jaydenchee97 mentioned this pull request Aug 28, 2024
Open
@azu-josh azu-josh mentioned this pull request Aug 28, 2024
Open
@phucle1010 phucle1010 mentioned this pull request Aug 29, 2024
Open
@Bonnie-TJ Bonnie-TJ mentioned this pull request Sep 4, 2024
Merged
@tanyipeng834 tanyipeng834 mentioned this pull request Sep 4, 2024
Open
@arenault-pass arenault-pass mentioned this pull request Sep 6, 2024
Closed
@mhmoudmhmed mhmoudmhmed mentioned this pull request Sep 7, 2024
Open
This was referenced Sep 7, 2024
Closed
Closed
@phucle1010 phucle1010 mentioned this pull request Sep 24, 2024
Open
@arenault-pass arenault-pass mentioned this pull request Sep 24, 2024
Closed
@waveyboym waveyboym mentioned this pull request Sep 24, 2024
Open
@waveyboym waveyboym mentioned this pull request Sep 24, 2024
Open
@SanteriMertakorpi SanteriMertakorpi mentioned this pull request Sep 24, 2024
Merged
This was referenced Sep 25, 2024
Closed
Closed
Closed
@ananichoumchoum ananichoumchoum mentioned this pull request Sep 27, 2024
Open
@arenault-pass arenault-pass mentioned this pull request Sep 28, 2024
Closed
@yingbull yingbull mentioned this pull request Sep 28, 2024
Closed
@manh20012000 manh20012000 mentioned this pull request Sep 29, 2024
Open
@Alaa-1074002 Alaa-1074002 mentioned this pull request Sep 29, 2024
Open
@manh20012000 manh20012000 mentioned this pull request Oct 1, 2024
Open
This was referenced Oct 1, 2024
Closed
Closed
@phucle1010 phucle1010 mentioned this pull request Oct 2, 2024
Open
This was referenced Oct 3, 2024
Closed
Closed
This was referenced Oct 4, 2024
Closed
Closed
This was referenced Oct 5, 2024
Closed
Closed
@phucle1010 phucle1010 mentioned this pull request Oct 25, 2024
Open
@0xk4b1r 0xk4b1r mentioned this pull request Oct 28, 2024
Closed
@yingbull yingbull mentioned this pull request Oct 28, 2024
Closed
@phucle1010 phucle1010 mentioned this pull request Nov 1, 2024
Open
@Abyss0108 Abyss0108 mentioned this pull request Nov 3, 2024
Open
@0xk4b1r 0xk4b1r mentioned this pull request Nov 4, 2024
Closed
@PoojaPanchal12 PoojaPanchal12 mentioned this pull request Nov 5, 2024
Open
@edwardsph edwardsph mentioned this pull request Nov 6, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@szydlovsky szydlovsky szydlovsky approved these changes

@piaskowyk piaskowyk piaskowyk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@latekvo @piaskowyk @szydlovsky