-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Workletizable Classes #6230
Merged
Merged
Workletizable Classes #6230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Base automatically changed from
@tjzel/plugin/context-objects
to
@tjzel/plugin/allow-file-workletization
July 17, 2024 11:28
tjzel
force-pushed
the
@tjzel/plugin/allow-file-workletization
branch
from
July 17, 2024 11:29
4dcf605
to
d6fcab1
Compare
tjzel
force-pushed
the
@tjzel/plugin/classes
branch
from
July 17, 2024 14:56
3d7e69b
to
7422591
Compare
bartlomiejbloniarz
requested changes
Jul 18, 2024
bartlomiejbloniarz
approved these changes
Jul 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚗
This was referenced Sep 24, 2024
This was referenced Oct 1, 2024
This was referenced Oct 3, 2024
This was referenced Oct 4, 2024
This was referenced Oct 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request features running classes on the Worklet runtime. Classes aren't supported by Hermes and require polyfilling.
Current implementation is a bit naive.
We could could put the class in the global scope, however it doesn't seem exactly necessary at the moment.
You can obtain a worklet class explicitly by adding a ClassProperty
__workletClass
to itor implicitly by placing it in a file with a worklet directive.
Test plan