Fix inverted FlatList#5295
Merged
bartlomiejbloniarz merged 3 commits intoOct 30, 2023
Merged
Conversation
tomekzaw
reviewed
Oct 23, 2023
piaskowyk
reviewed
Oct 24, 2023
Member
piaskowyk
left a comment
piaskowyk
left a comment
There was a problem hiding this comment.
Just one more thinks, leave a note in PR description that you check if it works fine for older RN versions too
piaskowyk
approved these changes
Oct 30, 2023
tomekzaw
approved these changes
Oct 30, 2023
bartlomiejbloniarz
deleted the
@bartlomiejbloniarz/fix-inverted-flatlist
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR changes how reanimated treats inverted
FlatLists. In #3765 our implementation was changed to mimic the react-native behavior by assigning a special style that reverts the cell inversion (inverted FlatList flips the entire view and then flips back every cell). In react-native@0.72.4 the inversion style was changed on android due to some performance issues. That change combined with our implementation was causing the cell to remain inverted on android (since both styles were being applied). This PR changes our implementation to instead allow theCellRendererComponentto receive a style prop, making react solely responsible for the cell inversion.Test plan
Check whether the Inverted FlatList Example behaves properly on android.
I tested the example on all rn versions from rn@0.69