Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run cpplint GH action as standalone lint #2067

Merged
merged 3 commits into from
May 28, 2021

Conversation

mrousavy
Copy link
Contributor

@mrousavy mrousavy commented May 28, 2021

GitHub actions running from forks are not allowed to access secrets, which denied the previous reviewdog GH action to start a review with inline codeblock comments. This PR removes reviewdog entirely and simply runs cpplint as a normal command, meaning you will have to check out the GH action output's stderr for any errors - which isn't as convenient as before, but it works fine.

@mrousavy mrousavy changed the title Move cpplint GH action to Travis Fix cpplint GH action May 28, 2021
@jakub-gonet jakub-gonet changed the title Fix cpplint GH action Run cpplint GH action as standalone lint May 28, 2021
@jakub-gonet jakub-gonet merged commit accc39d into software-mansion:master May 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants