[MacOS] Fix Pressable being unresponsive
#3142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
latekvo
changed the title
Pressable being unresponsive
m-bert
approved these changes
Oct 8, 2024
m-bert
approved these changes
Oct 8, 2024
j-piasecki
approved these changes
Oct 9, 2024
latekvo
deleted the
@latekvo/fix-pointer-tracker-relative-coords-on-macos
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes incorrect
Pressablebehaviour onMacOS, which was caused by the following sub-issues:Pointer tracker on
MacOSkept returning incorrect relative coordinates.This was caused by converting the
absolutecoordinates from thelocalcoordinate space to theabsolutecoordinate space instead of the other way around.There was no workflow set on the
Gesture.Native()to allow for activation ofPressableTest plan
Pressableexample onMacOS