Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Android] Drop support for AGP version <= 7 #3077

Merged
merged 4 commits into from
Sep 2, 2024
Merged

[Android] Drop support for AGP version <= 7 #3077

merged 4 commits into from
Sep 2, 2024

Conversation

latekvo
Copy link
Contributor

@latekvo latekvo commented Aug 29, 2024 •
edited
Loading

Description

This PR removes support for Android Gradle Plugin version <= 7
AGP version 7 is unsupported by React Native since 0.73

Closes: #2725

Test plan

  • build example Android app while using AGP 8.0
  • build example Android app while using AGP 9.0
  • both should run successfully

j-piasecki
j-piasecki reviewed Aug 29, 2024
View reviewed changes
android/build.gradle Outdated Show resolved Hide resolved
@latekvo @j-piasecki
uniform assignment notation
5460682 
Co-authored-by: Jakub Piasecki <jakub.piasecki@swmansion.com>
@latekvo latekvo mentioned this pull request Aug 29, 2024
Closed
@latekvo latekvo merged commit aa5c9f8 into main Sep 2, 2024
4 checks passed
@latekvo latekvo deleted the @latekvo/drop-agp-7-support branch September 2, 2024 07:43
@migueldaipre migueldaipre mentioned this pull request Sep 3, 2024
Closed
@SanteriMertakorpi SanteriMertakorpi mentioned this pull request Sep 23, 2024
Open
@yingbull yingbull mentioned this pull request Sep 28, 2024
Closed
@Adam-1052189 Adam-1052189 mentioned this pull request Sep 28, 2024
Open
@Alaa-1074002 Alaa-1074002 mentioned this pull request Sep 29, 2024
Open
@ColeCoffman ColeCoffman mentioned this pull request Oct 2, 2024
Open
@santiko santiko mentioned this pull request Oct 3, 2024
Open
@Abyss0108 Abyss0108 mentioned this pull request Nov 3, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@j-piasecki j-piasecki j-piasecki approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Warning with Task :react-native-gesture-handler:processDebugManifest
2 participants
@latekvo @j-piasecki