Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unify Vector-related constant naming scheme across Web and Android implementations #3052

Merged
merged 5 commits into from
Aug 21, 2024
Merged

Unify Vector-related constant naming scheme across Web and Android implementations #3052

merged 5 commits into from
Aug 21, 2024

Conversation

latekvo
Copy link
Contributor

@latekvo latekvo commented Aug 21, 2024

Description

Rename constant determining whether magnitude is sufficient to MINIMAL_RECOGNIZABLE_MAGNITUDE on both Web and Android

Test plan

not applicable

@latekvo latekvo requested a review from m-bert August 21, 2024 11:02
@latekvo latekvo marked this pull request as ready for review August 21, 2024 11:22
@m-bert
Copy link
Contributor

m-bert commented Aug 21, 2024

Test plan
not applicable

I hope you've tested that both implementations work? 😅

@latekvo
Copy link
Contributor Author

latekvo commented Aug 21, 2024

I hope you've tested that both implementations work? 😅

I did :)

@latekvo latekvo merged commit 7346c2f into main Aug 21, 2024
4 checks passed
@latekvo latekvo deleted the @latekvo/remove-fling-references-in-vector branch August 21, 2024 11:54
@SanteriMertakorpi SanteriMertakorpi mentioned this pull request Sep 23, 2024
Open
@yingbull yingbull mentioned this pull request Sep 28, 2024
Closed
@Adam-1052189 Adam-1052189 mentioned this pull request Sep 28, 2024
Open
@Alaa-1074002 Alaa-1074002 mentioned this pull request Sep 29, 2024
Open
@ColeCoffman ColeCoffman mentioned this pull request Oct 2, 2024
Open
@santiko santiko mentioned this pull request Oct 3, 2024
Open
@Abyss0108 Abyss0108 mentioned this pull request Nov 3, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m-bert m-bert m-bert approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@latekvo @m-bert