-
-
Notifications
You must be signed in to change notification settings - Fork 980
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update examples #2919
Update examples #2919
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job! I really like new look of our app ❤️
I've left some suggestions, let me know what do you think about them.
Also there's one problem - transformations
example no longer works on web. Could you please check that?
Also, one more detail
I think that combo example still uses |
Most likely yes. Update: removed in 156c3bc |
Co-authored-by: Michał Bert <63123542+m-bert@users.noreply.github.com>
Co-authored-by: Michał Bert <63123542+m-bert@users.noreply.github.com>
… @jpiasecki/update-examples
It seems like passing the matrix as transform directly didn't work on web. Now it applies styles, but they are not right. It looks like on web |
You can open an issue. I will look into it later 😅 |
… @jpiasecki/update-examples
I've moved the complex transform logic to the separate PR so this stops being blocked by wrong anchor/focal points on web - #3124 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've moved the complex transform logic to the separate PR so this stops being blocked by wrong anchor/focal points on web - #3124
So I think we can remove matrices from description:
updates Transformations to use matrices and update the look
Description
New Api
section to the topVelocity Test
withSimple Reanimated example
Overlap Parent
andOverlapSiblings
Transformations
Camera
since the camera was missing therePan Responder
to not usesetNativeProps
which was removed on RN webTest plan
Check the updated examples