fix: android - onstart on pinch gesture handler #1798
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR attempts to fix
onStart
callback on android withPinchGestureHandler
and resolve the below inconsistency on android and iOS. Fixes #553On iOS
On Android
focalX
andfocalY
are always 0 during onStart.This PR can cause a breaking change for someone who's depending upon using
onStart
for single-finger gestures on Android (doesn't seem very likely with PinchGestureHandler, but I am not sure!)Test plan
useAnimatedGestureHandler
as shown below and print values offocalX
andfocalY
ornumberOfPointers
inonStart
callback.onStart
on Android and iOS.onStart
should be called with 2 finger pinch (similar to iOS).focalX
andfocalY
should not be 0.