Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why does the build.gradle file of react-native-gesture-handler not need androidx androidx.appcompat: appcompat #967

Closed
Haibeike01 opened this issue Feb 13, 2020 · 0 comments · Fixed by #1447
Labels
Platform: Android This issue is specific to Android

Comments

@Haibeike01
Copy link

I found the react-native-gesture-handler component on github, the version is 1.5.6, it itself supports androidx, some java files in the project (such as react-native-gesture-handler / android / src / main / java / com / swmansion / gesturehandler / react / RNGestureHandlerPackage.java), you can see androidx.annotation.Nullable and other androidx classes, but I installed this component into my project, and the error was: androidx.annotation was not found .Nullable, I am very confused. I looked at the official android / build.gradle and found that the implementation 'androidx.appcompat: appcompat: 1.0.2' is missing.
image
So I can only add implementation 'androidx.appcompat: appcompat: 1.0.2' to the build-gradle file of react-native-gesture-handler in my project, and the result compiles.
I'm curious, why the official does not introduce this 'androidx.appcompat: appcompat: 1.0.2' dependency, he can still run, but the official RNGestureHandlerPackage and other classes it does need Nullable and other classes that need androidx, does it not Is it wrong?

@jakub-gonet jakub-gonet added the Platform: Android This issue is specific to Android label Sep 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Platform: Android This issue is specific to Android
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants