-
-
Notifications
You must be signed in to change notification settings - Fork 975
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support hitSlop on Android buttons #328
Comments
Issue #283 mentions in the opening paragraph that "Android already has support for it." Is that not correct? |
as far as I can tell no https://github.com/kmagiera/react-native-gesture-handler/blob/master/android/src/main/java/com/swmansion/gesturehandler/react/RNGestureHandlerButtonViewManager.java - but it's very possible that i'm wrong |
I doesn't look like support 🤔 |
Heh, support is provided with |
interesting! thanks |
looks like on master that doesn't work anymore, and when i tried it on 1.0.15 it would increase the touch area as expected but onPress for the RectButton wrapped by NativeViewGestureHandler didn't fire |
@kmagiera @jakub-gonet @sakshya73 It's unclear, to me at least, if Android supports hitslop on buttons (BorderlessButton for instance). I can't get it to work. But perhaps i'm doing something wrong... But the docs nor the issues on github seem to be conclusive about if support is actually there... |
Thanks to @janicduplessis this is supported on iOS, it'd be useful to have on Android as well.
The text was updated successfully, but these errors were encountered: