Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Pressable] Add keyboard support #2988

Closed
latekvo opened this issue Jul 11, 2024 · 2 comments
Closed

[Pressable] Add keyboard support #2988

latekvo opened this issue Jul 11, 2024 · 2 comments

Comments

@latekvo
Copy link
Contributor

latekvo commented Jul 11, 2024

Description

Current implementation of Pressable does not allow for keyboard input.
Keyboard input is an important accessibility feature present on most if not all other gh components, and all the core ones.

Here is a preview of the issue - as it is visible, I am unable to press the Pressable with the enter key.

Screen.Recording.2024-07-11.at.15.11.56.mov

blocked by: #2981
no longer blocked

Steps to reproduce

  1. Create a legacy and a gesturized Pressable component in one View.
  2. Add press indicators to both of the pressables (e.g.: functional styles)
  3. Start navigating with keyboard
  4. When over the legacy Pressable, press enter - element gets activated.
  5. When over the gesturized Pressable, press enter - no action happens.

Snack or a link to a repository

https://github.com/software-mansion/react-native-gesture-handler/blob/%40latekvo/fix-pressable-event-propagation/example/src/release_tests/nestedPressables/index.tsx

Gesture Handler version

n/a

React Native version

n/a

Platforms

Web

JavaScript runtime

None

Workflow

None

Architecture

None

Build type

None

Device

None

Device model

Web - all browsers

Acknowledgements

Yes

Copy link

Hey! 👋

The issue doesn't seem to contain a minimal reproduction.

Could you provide a snack or a link to a GitHub repository under your username that reproduces the problem?

@latekvo
Copy link
Contributor Author

latekvo commented Aug 9, 2024

Implemented by: #3035

@latekvo latekvo closed this as completed Aug 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants