Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confusing behavior of RN responder when used with RNGestureHandler needs to be documented #2629

Open
thomasttvo opened this issue Oct 10, 2023 · 2 comments
Assignees
Labels

Comments

@thomasttvo
Copy link

thomasttvo commented Oct 10, 2023

Description

We noticed that in RN, onShouldBlockNativeResponder does NOT have any effect on iOS. This is also mentioned in RN documentation. However, when a RN View is used inside RNGestureHandler, returning true in onShouldBlockNativeResponder DOES have an effect on iOS. This difference between RN and RNGestureHandler caused a bit of confusion and should probably be documented.

Upon investigating further, it looks like RNGestureHandler is replacing RN setJSResponder here with its own. Are there other differences in behaviors because of that? I think all these differences should be documented

Update: Looks like the Meta team said replacing setJSResponder is "guaranteed to break in the new architecture"

Gesture Handler version

2.11.0

React Native version

0.71

Platforms

iOS

JavaScript runtime

Hermes

Workflow

non-expo

Architecture

New

Acknowledgements

Yes

@github-actions github-actions bot added Platform: iOS This issue is specific to iOS Missing info labels Oct 10, 2023
@github-actions
Copy link

github-actions bot commented Oct 10, 2023

Hey! 👋

It looks like you've omitted a few important sections from the issue template.

Please complete Steps to reproduce and Snack or a link to a repository sections.

@github-actions
Copy link

Hey! 👋

The issue doesn't seem to contain a minimal reproduction.

Could you provide a snack or a link to a GitHub repository under your username that reproduces the problem?

@thomasttvo thomasttvo changed the title Confusing behavior of react-native JS responder needs to be documented Confusing behavior of RN responder when used with RNGestureHandler needs to be documented Oct 10, 2023
@j-piasecki j-piasecki self-assigned this Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants