Skip to content

Commit 9533e9d

Browse files
committed
CR changes
1 parent 9ea1f12 commit 9533e9d

File tree

2 files changed

+6
-9
lines changed

2 files changed

+6
-9
lines changed

lib/live_debugger_refactor/app/debugger/web/hook_components/dead_view_mode.ex

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -83,19 +83,16 @@ defmodule LiveDebuggerRefactor.App.Debugger.Web.HookComponents.DeadViewMode do
8383
end
8484

8585
defp handle_info(%UserChangedSettings{key: :dead_view_mode, value: value}, socket) do
86-
if value do
87-
put_private(socket, :dead_view_mode?, true)
88-
else
89-
put_private(socket, :dead_view_mode?, false)
90-
end
86+
socket
87+
|> put_private(:dead_view_mode?, value)
9188
|> halt()
9289
end
9390

9491
defp handle_info(%LiveViewDied{pid: pid}, %{private: %{pid: pid}} = socket) do
9592
if socket.private[:dead_view_mode?] do
9693
lv_process =
9794
socket.assigns.lv_process.result
98-
|> LvProcess.make_dead()
95+
|> LvProcess.set_alive(false)
9996
|> AsyncResult.ok()
10097

10198
socket

lib/live_debugger_refactor/structs/lv_process.ex

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -56,8 +56,8 @@ defmodule LiveDebuggerRefactor.Structs.LvProcess do
5656
}
5757
end
5858

59-
@spec make_dead(t()) :: t()
60-
def make_dead(%__MODULE__{} = lv_process) do
61-
%__MODULE__{lv_process | alive?: false}
59+
@spec set_alive(t(), boolean()) :: t()
60+
def set_alive(%__MODULE__{} = lv_process, alive?) when is_boolean(alive?) do
61+
%__MODULE__{lv_process | alive?: alive?}
6262
end
6363
end

0 commit comments

Comments
 (0)