Cleanup From/IntoAttributes traits #137
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Veetaha
force-pushed
the
feat/cleanup-from-into-attrs-traits
branch
3 times, most recently
from
26147f4 to
4cf057e
Compare
Renamed `fn from_mut_attrs` to `fn from_attrs` and removed the previous impl. Now in order to convert items to/from attrs by consuming them users should use generated `TryFrom<Attributes>/Into<Attributes>` impls.
Veetaha
force-pushed
the
feat/cleanup-from-into-attrs-traits
branch
from
4cf057e to
40b9d87
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Blocked by:
What did you implement:
Renamed
fn from_mut_attrstofn from_attrsand removed the previous impl.Now in order to convert items to/from attrs by consuming them users should use
generated
TryFrom<Attributes>/Into<Attributes>impls.How did you verify your change:
Ran existing tests
What (if anything) would need to be called out in the CHANGELOG for the next release:
from_attrsnow takesAttributesby a&mutreference, usetry_from()for convenient consuming of the attr map