feat: read the release assets asynchronously

[xen0n]

Previously all assets were being read synchronously into memory, making the action unsuitable for releasing very large assets. Because the client library allows stream body inputs (it just forwards it to the underlying fetch implementation), just do it.

Fixes: #353

[xen0n]

Note: I haven't tested this change myself, because my workflow takes 2 hours to finish and I have just finished one run, so I'm just uploading my 8GiB of assets manually this time to fix the release. Testing is welcome.

[chenrui333]

lgtm

[chenrui333]

@xen0n thanks a lot for your contribution!

[pattacini]

Unfortunately, this PR doesn't solve the problem reported in #353 (comment), at least in my case.

I was trying to upload a bunch of big files using globbing and the action failed with this fatal error:

##[error]The runner has received a shutdown signal. This can happen when the runner service is stopped, or a manually started runner is canceled.
##[error]The operation was canceled.

Here's my action, in case it helps:

name: Create Release

on: 
  workflow_dispatch:
    inputs:
      name:
        description: 'Release Name'
        required: true
        default: 'Project JL2 Camozzi Release v0.0.0'
      body:
        description: 'Release Body Message'
        required: true
        default: 'The asset provided by this release contains the whole material stored in the repository.'
      tag:
        description: 'Release Tag'
        required: true
        default: 'v0.0.0'
      zip_size:
        description: 'Max size of zip files in GB'
        required: true
        default: '1'

env:
  DIR_PREFIX: project-jl2-camozzi

jobs:
  doRelease:
    name: "Release"
    runs-on: ubuntu-latest
    environment: release_environment

    steps:
      - name: Release Inputs
        run: |
          echo "Release Inputs:"
          echo "- Name: ${{ inputs.name }}" 
          echo "- Body: ${{ inputs.body }}" 
          echo "- Tag: ${{ inputs.tag }}" 
          echo "- Zip Size: ${{ inputs.zip_size }}g"

      - name: Clone Branch master
        uses: actions/checkout@main
        with:
          ref: master
          path: ${{ env.DIR_PREFIX }}-${{ inputs.tag }}/master
          lfs: true

      - name: Clone Branch mech
        uses: actions/checkout@main
        with:
          ref: mech
          path: ${{ env.DIR_PREFIX }}-${{ inputs.tag }}/mech
          lfs: true

      - name: Clone Branch sim
        uses: actions/checkout@main
        with:
          ref: sim
          path: ${{ env.DIR_PREFIX }}-${{ inputs.tag }}/sim
          lfs: true

      - name: Clone Branch code
        uses: actions/checkout@main
        with:
          ref: code
          path: ${{ env.DIR_PREFIX }}-${{ inputs.tag }}/code
          lfs: true

      - name: Clone Branch astrial/code
        uses: actions/checkout@main
        with:
          ref: astrial/code
          path: ${{ env.DIR_PREFIX }}-${{ inputs.tag }}/astrial/code
          lfs: true
          
      - name: Clone Branch astrial/hailo-dev
        uses: actions/checkout@main
        with:
          ref: astrial/hailo-dev
          path: ${{ env.DIR_PREFIX }}-${{ inputs.tag }}/astrial/hailo-dev
          lfs: true 

      - name: Clone Branch firmware
        uses: actions/checkout@main
        with:
          ref: firmware
          path: ${{ env.DIR_PREFIX }}-${{ inputs.tag }}/firmware
          lfs: true

      - name: Configure Git
        run: |
          git config --global push.default upstream
          git config --global user.name "GitHub Actions"
          git config --global user.email "actions@github.com"

      - name: Tag Branches
        run: |
          declare -a branches=("master" "mech" "sim" "code" "astrial/code" "astrial/hailo-dev" "firmware")
          for branch in ${branches[@]}; do
            echo "tagging ${branch}..."
            cd ${GITHUB_WORKSPACE}/${DIR_PREFIX}-${{ inputs.tag }}/${branch}
            git tag -a ${branch}-${{ inputs.tag }} -m "version ${{ inputs.tag }}"
            git remote set-url origin https://x-access-token:${{ secrets.GITHUB_TOKEN }}@github.com/${{ github.repository }}.git
            git push origin --tags
            rm -Rf .git
          done

      - name: Create Assets
        run: |
          zip -r -s ${{ inputs.zip_size }}g ${DIR_PREFIX}-${{ inputs.tag }}.zip ${DIR_PREFIX}-${{ inputs.tag }}/
          
      - name: Create Release
        uses: softprops/action-gh-release@v2
        with:
          tag_name: master-${{ inputs.tag }}
          name: ${{ inputs.name}}
          body: ${{ inputs.body }}
          generate_release_notes: false
          make_latest: true
          files: |
            ${{ env.DIR_PREFIX }}-${{ inputs.tag }}.*

cc @xen0n @chenrui333

[pattacini]

Hi @xen0n @chenrui333
Any comment/update on what I posted above?
Did you manage to reproduce the problem on your end?

[xen0n]

Hi @xen0n @chenrui333 Any comment/update on what I posted above? Did you manage to reproduce the problem on your end?

Hi, while I didn't run your exact reproducer, is #562 working for you? You can test by pinning to the commit:

- uses: softprops/action-gh-release@d67838e5786c2eec2084db89e3a60f3587b9b4d9  # softprops/action-gh-release#562

(change "softprops" to "xen0n" should the reference not work)

[pattacini]

Hi @xen0n

I didn't notice the fix you proposed in #562.
Awesome! I'll check it asap and keep you posted!

[pattacini]

Hi @xen0n

I've tested the fix and it worked like a charm! 🚀

[devnoname120]

Do you think this regression could be related to this pull request?
#556

[pattacini]

Don't know, @devnoname120.